executor: fix incorrect results when there is an IndexLookUp under the inner side of an Apply #19496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/bugfix
ti-srebot
approved these changes
Aug 26, 2020
XuHuaiyu
approved these changes
Aug 26, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/run-all-tests |
|
/run-integration-copr-test |
1 similar comment
|
/run-integration-copr-test |
|
/run-integration-common-test |
1 similar comment
|
/run-integration-common-test |
|
/merge |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/run-common-test |
1 similar comment
|
/run-common-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 27, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #19508 |
jebter
pushed a commit
that referenced
this pull request
Aug 27, 2020
…e inner side of an Apply (#19496) (#19508) * cherry pick #19496 to release-4.0 Signed-off-by: ti-srebot <[email protected]> * fix CI Co-authored-by: Yuanjia Zhang <[email protected]>
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19372
Problem Summary: executor: fix incorrect results when there is an IndexLookUp under the inner side of an Apply
What is changed and how it works?
When an
IndexLookUpis under the inner side of anApply, it may be invoked multiple times, but inIndexLookUp.Close(), the fieldresultCurris not cleared up, so in the next round of invocation, some stale rows may be returned because of this logic.Check List
Tests
Release note