-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix show global variables return session variables also #19341
Conversation
@fzhedu PTAL |
@ti-srebot /run-all-test |
/run-all-test |
@ti-srebot /run-all-tests |
/run-all-tests |
Your branch is up to date with 'origin/showvar'. Changes to be committed: modified: executor/show_test.go
@ti-srebot /rebuild |
@ti-srebot /run-all-tests |
/run-all-tests |
@ti-srebot /run-common-test |
/run-common-test |
@ti-srebot /run-all-tests |
@qw4990 PTAL |
@ti-srebot /run-all-tests |
@erwadba Please pick the issue again. |
/pick-up |
Pick up success. DetailsTip :
Warning: |
Please comment |
picked |
/reward 300 |
Reward success. |
@erwadba, Congratulations, you get 300 in this PR, and your total score is 300 in high-performance challenge program. |
It's merged. Thanks for your contribution :D @erwadba |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #20764 |
@erwadba You did not submit PR within 7 days, so give up automatically. |
…9341) (#21045) Signed-off-by: ti-srebot <[email protected]>
…also (pingcap#19341) (pingcap#21045)" This reverts commit a1bdbef.
…also (pingcap#19341) (pingcap#21045)" This reverts commit a1bdbef.
…also (pingcap#19341)" This reverts commit cc7a383.
What problem does this PR solve?
Issue Number: close #18517
Problem Summary: To fix show global variables statement return session variables.
What is changed and how it works?
What's Changed:
Rewrite the function fetchShowVariables() to distinguish global var from session var.
How it Works:
Related changes
n/a
Check List
Tests
Side effects
n/a
Release note