ddl: fix db charset modification panic in an uppercase schema #19286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
previously approved these changes
Aug 19, 2020
bb7133
reviewed
Aug 19, 2020
bb7133
added
require-LGT3
|
LGTM |
ti-srebot
approved these changes
Aug 19, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@tangenta merge failed. |
|
/run-integration-ddl-test |
|
/run-check_dev |
1 similar comment
|
/run-check_dev |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 19, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #19301 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 19, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #19302 |
ti-srebot
added a commit
that referenced
this pull request
Aug 20, 2020
#19302) Signed-off-by: ti-srebot <[email protected]>
zz-jason
pushed a commit
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19273
Problem Summary:
The database name should be changed to lower case before passing it into
copySchemaTables.What is changed and how it works?
What's Changed: Omitted.
How it Works: Omitted.
Related changes
Check List
Tests
Side effects
N/A
Release note