-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make join work when keys are bigint and bit (#19032) #19213
executor: make join work when keys are bigint and bit (#19032) #19213
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lzmhhh123 would you like to help to resolve the conflict and fix the CI?
@ti-srebot, please update your pull request. |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
/rebuild |
LGTM |
/run-all-tests |
cherry-pick #19032 to release-3.0
What problem does this PR solve?
Issue Number: close #11896
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Only if integers have no unsigned flag and are negative, treat them as signed integers. Otherwise, just treat them as unsigned numbers so that the comparison between an integer and a bit set will be as expected.
How it Works:
Related changes
Check List
Tests
Release note