Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: make single partition table support index join on inner side (#19151) #19197

Merged
merged 3 commits into from
Aug 21, 2020
Merged

planner: make single partition table support index join on inner side (#19151) #19197

merged 3 commits into from
Aug 21, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19151 to release-4.0

What problem does this PR solve?

Issue Number: close #19145

What is changed and how it works?

What's Changed: append partition info for table scan on inner side of index join.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • make single partition table support index join on the inner side.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 14, 2020
Merged
@ti-srebot ti-srebot added priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/executor sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Aug 14, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 14, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor Author

@tiancaiamao,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: planner(slack).

@github-actions github-actions bot added the sig/execution SIG execution label Aug 20, 2020
SunRunAway
SunRunAway reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2020
winoros
winoros approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 21, 2020
@winoros
Copy link
Member

winoros commented Aug 21, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @winoros, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@jebter
Copy link

jebter commented Aug 21, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit fb95293 into pingcap:release-4.0 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@winoros winoros winoros approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

@lzmhhh123 lzmhhh123

Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @tiancaiamao @winoros @jebter @SunRunAway @AndreMouche @lzmhhh123