Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix wrong hash key for decimal (#19131) #19187

Closed
wants to merge 4 commits into from
Closed

types: fix wrong hash key for decimal (#19131) #19187

wants to merge 4 commits into from

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19131 to release-3.1

What problem does this PR solve?

Issue Number: close #19112

What is changed and how it works?

What's Changed: MyDecimal.ToHashKey should consider the length of int and Frac.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • fix wrong hash key for decimal

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 13, 2020
Merged
@ti-srebot ti-srebot added component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/executor type/3.1-cherry-pick type/bugfix This PR fixes a bug. labels Aug 13, 2020
@ti-srebot ti-srebot added this to the v3.1.3 milestone Aug 13, 2020
SunRunAway
SunRunAway reviewed Aug 14, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
qw4990
qw4990 previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@github-actions github-actions bot added the sig/execution SIG execution label Aug 20, 2020
@zz-jason
Copy link
Member

@lzmhhh123 please fix CI.

@lzmhhh123
Copy link
Contributor

/run-all-tests

@lzmhhh123
Copy link
Contributor

/run-sqllogic-test-1
/run-unit-test

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 left review comments

@breezewish breezewish Awaiting requested review from breezewish

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@lzmhhh123 lzmhhh123

Labels
component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @SunRunAway @zz-jason @lzmhhh123 @qw4990 @AndreMouche @wjhuang2016