-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix wrong hash key for decimal (#19131) #19185
Merged
ti-srebot
merged 3 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-0448a5487519
Aug 14, 2020
Merged
types: fix wrong hash key for decimal (#19131) #19185
ti-srebot
merged 3 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-0448a5487519
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
ti-srebot
added
component/expression
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/executor
type/3.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Aug 13, 2020
wshwsh12
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SunRunAway
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 14, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 14, 2020
SunRunAway
approved these changes
Aug 14, 2020
/run-all-tests |
/merge |
@ti-srebot merge failed. |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19131 to release-3.0
What problem does this PR solve?
Issue Number: close #19112
What is changed and how it works?
What's Changed:
MyDecimal.ToHashKey
should consider the length ofint
andFrac
.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note