-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add store type to statement summary (#17825) #19159
planner: add store type to statement summary (#17825) #19159
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NormalizePlanNode
is untouched, so different store types result in the same plan digest.
Is that right? @crazycs520
Great catch, I think it is a bug, @pingyu Could you pull another PR to fix it? |
Okay, no problem~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@ti-srebot merge failed. |
cherry-pick #17825 to release-4.0
What problem does this PR solve?
Issue Number: close #17278
Problem Summary:
What is changed and how it works?
What's Changed:
Add store type to
plan
ininformation_schema.statements_summary
How it Works:
Read store type from physical plan, and add to
plan
field.Related changes
Check List
Tests
Release note