expression, executor: reset e.done for PointGetExecutor #19046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
ti-srebot
approved these changes
Aug 6, 2020
|
/run-check-dev |
|
/run-check_dev |
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the master branch does not have this problem, I do not check why.
But the modification in this PR will still be cherrypicked to the master branch.
What problem does this PR solve?
Issue Number: close #19045
Problem Summary:
Apply will Open-Close PointGetExecutor again and again, we need to reset the status attribute.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
N/A
Check List
Tests
Side effects
N/A
Release note