store: add lock for runtime stats to fix panic caused by concurrent execution (#18983) #18991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
component/executor
sig/execution
|
/run-unit-tests |
ti-srebot
added
status/LGT2
crazycs520
added
the
priority/release-blocker
jebter
approved these changes
Aug 5, 2020
|
/merge |
jebter
added
the
status/can-merge
|
/run-all-tests |
|
/merge |
bezmax
reviewed
Aug 5, 2020
| @@ -54,6 +54,15 @@ func (s *testSuiteJoin1) TestJoinPanic(c *C) { | |||
| tk.MustQuery("SELECT * FROM events e JOIN (SELECT MAX(clock) AS clock FROM events e2 GROUP BY e2.source) e3 ON e3.clock=e.clock") | |||
| err := tk.ExecToErr("SELECT * FROM events e JOIN (SELECT clock FROM events e2 GROUP BY e2.source) e3 ON e3.clock=e.clock") | |||
| c.Check(err, NotNil) | |||
|
|
|||
| // Test for PR 18983, use to detect race. | |||
| tk.MustExec("use test") | |||
There was a problem hiding this comment.
I have tried running this on different TiDB versions, and it is consistently green after and before the fix. I understand that this is a race condition bug and it only happens occasionally, but I doubt that the test that only fails once in a lifetime is really that useful.
There was a problem hiding this comment.
Sorry for that, this test is really hard to reproduce, I haven't found a stable reproduction method yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18983 to release-4.0
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
fix #18985
What is changed and how it works?
Related changes
Check List
Tests
Side effects
Release note