Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: resolve errors caused by in null in point/batch . #18863

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 29, 2020

cherry pick for #18848


What problem does this PR solve?

Issue Number: close #18839

Problem Summary: resolve errors caused by in null in point/batch get operators

What is changed and how it works?

Skip null values when casting.

Check List

Tests

  • Unit test

Release note

  • executor: resolve errors caused by in null in point/batch get operators

@qw4990 qw4990 requested review from tiancaiamao and bb7133 July 29, 2020 08:35
@qw4990 qw4990 added sig/execution SIG execution type/bugfix This PR fixes a bug. labels Jul 29, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 29, 2020
@imtbkcat
Copy link

/run-all-tests tidb-test=release-4.0 tikv=release-4.0 pd=release-4.0

@imtbkcat
Copy link

/rebuild

@jackysp jackysp merged commit 7fde4bd into pingcap:release-4.0.4 Jul 29, 2020
@imtbkcat imtbkcat added this to the v4.0.4 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants