executor: fix batch point get return wrong result for in(null) #18851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
sig/execution
|
PTAL @zz-jason |
|
4.0 PR #18848 |
coocood
reviewed
Jul 29, 2020
executor/point_get.go
Outdated
| @@ -339,6 +339,10 @@ func (e *PointGetExecutor) get(ctx context.Context, key kv.Key) ([]byte, error) | |||
| func EncodeUniqueIndexKey(ctx sessionctx.Context, tblInfo *model.TableInfo, idxInfo *model.IndexInfo, idxVals []types.Datum, tID int64) (_ []byte, err error) { | |||
| sc := ctx.GetSessionVars().StmtCtx | |||
| for i := range idxVals { | |||
| if idxVals[i].IsNull() { | |||
There was a problem hiding this comment.
I think is no the right place to fix the bug.
The idxVals should be skipped in higher level.
There was a problem hiding this comment.
We should let the caller know the built key is not valid.
Codecov Report
@@ Coverage Diff @@
## master #18851 +/- ##
===========================================
Coverage 79.1582% 79.1582%
===========================================
Files 546 546
Lines 147718 147718
===========================================
Hits 116931 116931
Misses 21342 21342
Partials 9445 9445 |
imtbkcat
added
the
priority/release-blocker
|
LGTM |
ti-srebot
approved these changes
Jul 29, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@tiancaiamao merge failed. |
|
/run-check_dev_2 |
|
/merge |
|
/run-all-tests |
ti-srebot
added
status/LGT3
|
@tiancaiamao merge failed. |
|
LGTM |
|
@AndreMouche,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack). |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18843
Problem Summary:
What is changed and how it works?
What's Changed:
When constucting point get index key, the datum is convert to the column type.
If the datum is null, convert it to string would construct the wrong index key.
How it Works:
Do not convert the datum if it's null.
Related changes
Check List
Tests
Release note