store/tikv: fix BatchPointGet wrong result. #18814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18814 +/- ##
================================================
+ Coverage 79.1288% 79.1636% +0.0347%
================================================
Files 544 544
Lines 147026 146921 -105
================================================
- Hits 116340 116308 -32
+ Misses 21269 21208 -61
+ Partials 9417 9405 -12 |
ti-srebot
approved these changes
Jul 28, 2020
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@coocood merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 28, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #18815 |
jackysp
pushed a commit
that referenced
this pull request
Jul 28, 2020
imtbkcat
pushed a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
in-transaction BatchPointGet returns wrong result in certain case.
What is changed and how it works?
Do not modify input keys slice when do snapshot batch get.
Related changes
Check List
Tests
Release note