Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Uncomment join test #18697

Merged
merged 3 commits into from Aug 25, 2020
Merged

executor: Uncomment join test #18697

merged 3 commits into from Aug 25, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2020

What problem does this PR solve?

Issue Number: Fixes #11895

Problem Summary:

What is changed and how it works?

What's Changed:

Re-enable a test now that it passes again.

How it Works:

Tests only.

Related changes

None

Check List

Tests

  • Unit test
  • No code

Side effects

  • None

Release note

  • No release note

@ghost ghost self-requested a review as a code owner July 21, 2020 02:03
@ghost ghost requested review from SunRunAway and removed request for a team July 21, 2020 02:03
@github-actions github-actions bot added the sig/execution SIG execution label Jul 21, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 14, 2020
@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19139
  • 19379
  • 19363
  • 19441
  • 19308

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19363
  • 19441
  • 19308
  • 19154
  • 19020
  • 19139
  • 19379
  • 19363
  • 19308

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 30456df into pingcap:master Aug 25, 2020
@ghost ghost deleted the fix-11895 branch October 20, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/executor sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not insert -1 as Type BIT
4 participants