-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
region_cache: invalidate cached region for not leader error (#18577) #18598
Merged
ti-srebot
merged 3 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-07bd4dd261e1
Jul 24, 2020
Merged
region_cache: invalidate cached region for not leader error (#18577) #18598
ti-srebot
merged 3 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-07bd4dd261e1
Jul 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
ti-srebot
added
component/tikv
type/3.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Jul 15, 2020
@hicqu please accept the invitation then you can push to the cherry-pick pull requests. |
@hicqu please help address conflict |
/run-all-tests |
1 similar comment
/run-all-tests |
hicqu
previously approved these changes
Jul 24, 2020
LGTM |
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jul 24, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jul 24, 2020
/run-all-tests |
@ti-srebot merge failed. |
Signed-off-by: qupeng <[email protected]>
hicqu
force-pushed
the
release-3.0-07bd4dd261e1
branch
from
July 24, 2020 08:03
755d809
to
4548f61
Compare
XuHuaiyu
approved these changes
Jul 24, 2020
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/tikv
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18577 to release-3.0
Signed-off-by: qupeng [email protected]
What problem does this PR solve?
In this case TiDB could report "region is unavailable":
A Region peer is isolated from its Raft group during it's being removed from the group. So it will never know who is the current leader of the Raft group. If TiDB sends requests to the peer, it will always report
not leader, leader maybe None
, which won't reload the cached region information.What is changed and how it works?
Invalidate cached region information for this error.
Related changes
Check List
Tests
Side effects
Release note