util/execdetails: refactor execdetails information of runtime collect #18530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
|
/run-all-tests |
qw4990
reviewed
Jul 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #18530 +/- ##
===========================================
Coverage 79.7346% 79.7346%
===========================================
Files 541 541
Lines 147404 147404
===========================================
Hits 117532 117532
Misses 20499 20499
Partials 9373 9373 |
Signed-off-by: crazycs520 <[email protected]>
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Jul 15, 2020
SunRunAway
approved these changes
Jul 15, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@crazycs520 merge failed. |
|
/run-all-tests |
|
/run-check_dev_2 |
|
/run-integration-copr-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 15, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #18592 |
25 tasks
ti-srebot
added a commit
that referenced
this pull request
Jul 28, 2020
…#18530) (#18592) Signed-off-by: ti-srebot <[email protected]> Signed-off-by: crazycs520 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR refactor
execdetailsinformation of runtime collect. This will make it easy and efficient to add special runtime information for the separated executors.What is changed and how it works?
Before this PR, all executor runtime information was expressed by
execdetails.RuntimeStats. But different executor maybe has different runtime information, then theexecdetails.RuntimeStatsbecomes very huge and redundant.This PR use
execdetails.RuntimeStatsinterface instead of ``execdetails.RuntimeStats` struct.Related changes
Check List
Tests
Side effects
Release note