*: multi-query prefetch support pessimistic transaction #18439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
requested review from
qw4990,
lysu and
bobotu
and removed request for
a team
jackysp
reviewed
Jul 8, 2020
| // we can get the keys from the lock cache. | ||
| // TODO: In the future we can support pre lock point keys for pessimistic transactions. | ||
| return nil, nil | ||
| if vars.IsReadConsistencyTxn() { |
There was a problem hiding this comment.
I think if it is a multi-query, we could prefetch data for RC transaction.
There was a problem hiding this comment.
We can do it in the future.
coocood
force-pushed
the
batch-update-pessimistic
branch
from
a6fc11b to
950b594
Compare
|
@lysu,Thanks for your review. |
ti-srebot
approved these changes
Jul 10, 2020
|
@jackysp,Thanks for your review. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@coocood merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #18439 +/- ##
================================================
+ Coverage 79.4223% 79.5849% +0.1625%
================================================
Files 540 540
Lines 144861 145990 +1129
================================================
+ Hits 115052 116186 +1134
+ Misses 20513 20487 -26
- Partials 9296 9317 +21 |
|
/merge |
|
/run-all-tests |
|
@coocood merge failed. |
|
/run-check_dev_2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Performance improvement.
What is changed and how it works?
Call lock keys for pessimistic transactions for multi-statement query.
So we can avoid RPC call during each statement execution.
Check List
Tests
Release note