types: fix STR_TO_DATE handling for %h, %r (#18171) #18428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ str_to_date('12:30:17', '%h:%i:%s') -> '00:30:17'
+ str_to_date('12:30:17PM', '%r') -> '12:30:17'
str_to_date('12:30:17AM', '%r') -> '00:30:17'
|
|
Codecov Report
@@ Coverage Diff @@
## master #18428 +/- ##
================================================
+ Coverage 79.2508% 79.4463% +0.1955%
================================================
Files 542 535 -7
Lines 146131 144237 -1894
================================================
- Hits 115810 114591 -1219
+ Misses 20994 20369 -625
+ Partials 9327 9277 -50 |
ti-srebot
approved these changes
Jul 21, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@dyzsr merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #18725 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.1 in PR #18726 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #18727 |
dyzsr
added a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 22, 2020
ti-srebot
added a commit
that referenced
this pull request
Jul 24, 2020
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added a commit
that referenced
this pull request
Jul 28, 2020
Signed-off-by: ti-srebot <[email protected]>
zz-jason
pushed a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18171
Problem Summary: Behavior of function
STR_TO_DATEis not compatible with MySQL.What is changed and how it works?
What's Changed:
How it Works:
mysqlTimeFixinspects the occurrence of '%h', '%p' and whether the hour part is 12.time12Hournow fixes the time when the hour part is 12.Tests
Side effects
No.
Release note