ddl: fix admin repair table with range partition expr will parseInt fail (#17982) #17988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <[email protected]>
|
/run-all-tests |
sre-bot
added
sig/sql-infra
|
/run-all-tests |
|
/merge |
|
Sorry @tiancaiamao, you don't have permission to trigger auto merge event on this branch. |
zz-jason
approved these changes
Jul 28, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17982 to release-4.0
Signed-off-by: AilinKid [email protected]
What problem does this PR solve?
Issue Number: close part of #17952
Problem Summary: partition expr will parse int fail while create table directly can be successfully
What is changed and how it works?
How it Works:
in function
buildTableInfoWithCheckcheckTableInfoValidWithStmtshould do the constant fold the partition expression firstly,then
checkTableInfoValidExtrawill pass the tableInfo check successfully secondly.while create table logic is different with this
Related changes
Check List
Tests
1: open repair mode and fill the repair list in config.toml
2: use SQL below to test admin repair action will work well rather than occur parseInt error.
Release note