Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] *: fix panic of command EXECUTE when printing an expensive query log #17874

Closed
wants to merge 5 commits into from

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Jun 9, 2020

What problem does this PR solve?

Issue Number: close #17419

Problem Summary:

session.currentPlan is not set when runs command EXECUTE, so that panic happens if the expensive log is printing.

What is changed and how it works?

  1. set session.currentPlan in EXECUTE statement
  2. recover the panic of logexpensivelog

What's Changed:

Set session.currentPlan when runs command EXECUTE

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • Fix panic of command EXECUTE when printing an expensive query log.

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Jun 9, 2020
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jun 9, 2020

LGTM

winoros
winoros previously approved these changes Jun 10, 2020
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SunRunAway SunRunAway requested review from a team as code owners June 19, 2020 07:53
@SunRunAway SunRunAway requested review from qw4990 and removed request for a team June 19, 2020 07:53
zz-jason
zz-jason previously approved these changes Jun 19, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Jun 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@SunRunAway merge failed.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #17874 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17874   +/-   ##
===========================================
  Coverage   79.5500%   79.5500%           
===========================================
  Files           526        526           
  Lines        143213     143213           
===========================================
  Hits         113926     113926           
  Misses        20108      20108           
  Partials       9179       9179           

@SunRunAway
Copy link
Contributor Author

/run-common-test

1 similar comment
@SunRunAway
Copy link
Contributor Author

/run-common-test

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18064

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@SunRunAway merge failed.

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway SunRunAway changed the title *: fix panic of command EXECUTE when printing an expensive query log [DNM] *: fix panic of command EXECUTE when printing an expensive query log Jun 19, 2020
@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor Author

/run-common-test

@qw4990 qw4990 removed their request for review July 10, 2020 08:26
@ti-srebot
Copy link
Contributor

@SunRunAway, please update your pull request.

@ti-srebot
Copy link
Contributor

@SunRunAway, please update your pull request.

@ti-srebot
Copy link
Contributor

@SunRunAway PR closed due to no update for a long time. Feel free to reopen it anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/executor sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execute sql panic
6 participants