-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] *: fix panic of command EXECUTE when printing an expensive query log #17874
Conversation
/run-all-tests |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@SunRunAway merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #17874 +/- ##
===========================================
Coverage 79.5500% 79.5500%
===========================================
Files 526 526
Lines 143213 143213
===========================================
Hits 113926 113926
Misses 20108 20108
Partials 9179 9179 |
/run-common-test |
1 similar comment
/run-common-test |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@SunRunAway merge failed. |
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-common-test |
@SunRunAway, please update your pull request. |
@SunRunAway, please update your pull request. |
@SunRunAway PR closed due to no update for a long time. Feel free to reopen it anytime. |
What problem does this PR solve?
Issue Number: close #17419
Problem Summary:
session.currentPlan
is not set when runs command EXECUTE, so that panic happens if the expensive log is printing.What is changed and how it works?
session.currentPlan
in EXECUTE statementWhat's Changed:
Set
session.currentPlan
when runs command EXECUTERelated changes
Check List
Tests
Release note