meta: fix the allocator batch size compute logic #17271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AilinKid
added
type/bugfix
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #17271 +/- ##
===========================================
Coverage 79.8700% 79.8700%
===========================================
Files 520 520
Lines 140005 140005
===========================================
Hits 111822 111822
Misses 19228 19228
Partials 8955 8955 |
|
/run-all-tests |
djshow832
reviewed
May 21, 2020
| n1 = CalcNeededBatchSize(newBase, int64(n), increment, offset, alloc.isUnsigned) | ||
| // Although the step is customized by user, we still need to make sure nextStep is big enough for insert batch. | ||
| if nextStep < n1 { | ||
| nextStep = n1 |
There was a problem hiding this comment.
It was n1*2 before but it's n1 now. Is that right?
There was a problem hiding this comment.
yes, allocate what you have asked for is correct
bb7133
added
the
priority/release-blocker
AilinKid
force-pushed
the
autoid_fix_batch_size_logic
branch
from
c8a5200 to
1922f0e
Compare
bb7133
added
status/LGT2
|
/run-all-tests |
|
/run-integration-copr-test |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-2.1 in PR #17547 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.0 in PR #17548 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #17549 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 1, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-4.0 in PR #17550 |
sre-bot
added a commit
that referenced
this pull request
Jun 1, 2020
sre-bot
added a commit
that referenced
this pull request
Jun 2, 2020
bb7133
pushed a commit
that referenced
this pull request
Jun 3, 2020
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Jun 4, 2020
bb7133
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: fix logic in allocator batch size computation
What is changed and how it works?
What's Changed:
when the local cache size if not enough for allocN, do the new batchSize computation based on the global new base in the txn.
so we postpone the NextStep adjustment to meta txn and store it after that.
Related changes
Check List
Tests
Release note