Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check plan type when executing explain format="dot". (#17144) #17160

Merged
merged 1 commit into from
May 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #17144 to release-4.0


What problem does this PR solve?

Issue Number: close #17141

What is changed and how it works?

Check plan type when executing explain format="dot".

Check List

Tests

  • Unit test

Release note

Check plan type when executing explain format="dot".

@sre-bot sre-bot requested review from a team as code owners May 13, 2020 04:59
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot added sig/execution SIG execution sig/planner SIG: Planner labels May 13, 2020
@ghost ghost requested a review from eurekaka May 13, 2020 04:59
@ghost ghost requested review from wshwsh12 and removed request for eurekaka and a team May 13, 2020 04:59
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 13, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway merged commit f636ac3 into pingcap:release-4.0 May 13, 2020
@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants