Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Support exchange partition #17149

Merged
merged 77 commits into from
Jun 10, 2020
Merged

ddl: Support exchange partition #17149

merged 77 commits into from
Jun 10, 2020

Conversation

zhaox1n
Copy link
Contributor

@zhaox1n zhaox1n commented May 12, 2020 •
edited
Loading

UCP #15005

What is changed and how it works?

Support exchange partition

Check List

Tests

  • Unit test

Release note

  • No release note

@zhaox1n zhaox1n requested a review from a team as a code owner May 12, 2020 16:42
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 2530 points.

@ghost ghost requested review from lzmhhh123 and removed request for a team May 12, 2020 16:42
@sre-bot sre-bot added the contribution This PR is from a community contributor. label May 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label May 12, 2020
@bb7133
Copy link
Member

bb7133 commented May 13, 2020

Hi @zhaox1n , thanks for your contribution!

Please fix the CI firstly(for example, https://internal.pingcap.net/idc-jenkins/job/tidb_ghpr_build/36145/display/redirect):

go: finding github.com/pingcap/parser v3.1.1+incompatible
[2020-05-12T16:43:26.250Z] # github.com/pingcap/tidb/util/memory
[2020-05-12T16:43:26.250Z] ../../tidb/util/memory/action.go:103:26: undefined: terror.ClassUtil

@bb7133 bb7133 requested review from tiancaiamao and Deardrops May 13, 2020 04:37
@zhaox1n zhaox1n mentioned this pull request May 13, 2020
Merged
Deardrops
Deardrops reviewed May 13, 2020
View reviewed changes
ddl/db_partition_test.go Show resolved Hide resolved
ddl/db_partition_test.go Show resolved Hide resolved
@lzmhhh123 lzmhhh123 removed their request for review June 8, 2020 04:57
zhaox1n
zhaox1n commented Jun 9, 2020
View reviewed changes
ddl/ddl_api.go
// Index type is not compatible
if sourceIdx.Tp != compatIdx.Tp ||
sourceIdx.Unique != compatIdx.Unique ||
sourceIdx.Primary != compatIdx.Primary {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazycs520 It has compared the Primary key here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they are different. For table create table t1 (a int key, b int, index (a));, the TableInfo.Indices is nil.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @crazycs520 PTAL

crazycs520
crazycs520 reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST LGTM

@tiancaiamao
Copy link
Contributor

Please resolve conflict @zhaox1n

@zimulala
Copy link
Contributor

@crazycs520
PTAL

crazycs520
crazycs520 reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jun 10, 2020
@crazycs520 crazycs520 added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

@zhaox1n merge failed.

@crazycs520
Copy link
Contributor

/run-unit-test

@tiancaiamao tiancaiamao merged commit 1cc33b0 into pingcap:master Jun 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

Team zhaox1n complete task #15005 and get 2530 score, current score 2730

@amyangfei amyangfei mentioned this pull request Jun 10, 2020
Closed
1 task
@zanmato1984 zanmato1984 mentioned this pull request Jun 10, 2020
Closed
@windtalker windtalker mentioned this pull request Jun 24, 2020
Merged
@zz-jason zz-jason modified the milestones: v5.0-rc, v5.0.0-alpha Jul 10, 2020
@xhebox xhebox mentioned this pull request Jan 13, 2021
Closed
@bb7133 bb7133 mentioned this pull request Aug 8, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@Deardrops Deardrops Deardrops left review comments

@july2993 july2993 july2993 left review comments

@amyangfei amyangfei amyangfei left review comments

@tiancaiamao tiancaiamao tiancaiamao left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. require-LGT3 Indicates that the PR requires three LGTM. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
v5.0.0-alpha
Development

Successfully merging this pull request may close these issues.

UCP: Exchanging Partitions with tables