Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: keep using origin goroutine when doing retry in commit phase (#16849) #16876

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 28, 2020

cherry-pick #16849 to release-4.0


What problem does this PR solve?

Issue Number: close #15995

Problem Summary:

make goroutine count in retry commit-phase can be controlled by committer-concurrency

What is changed and how it works?

Proposal: xxx

What's Changed:

no longer fork new goroutine when retry

How it Works:

no longer fork new goroutine when retry

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test, see commments above

Side effects

  • n/a

Release note

make goroutine count in retry commit-phase can be controlled by committer-concurrency


This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

@cfzjywxk
Copy link
Contributor

LGTM

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT3 The PR has already had 3 LGTM. label Apr 28, 2020
@jackysp
Copy link
Member

jackysp commented Apr 28, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

@sre-bot merge failed.

@jackysp
Copy link
Member

jackysp commented Apr 29, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot sre-bot merged commit cab6200 into pingcap:release-4.0 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants