-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: build right range when where stmt only have string column. (#16645) #16660
Conversation
/run-all-tests |
346ffcb
to
d0abe3e
Compare
Wait for #16559 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wshwsh12 please resolve conflict and fix CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry-pick #16645 to release-4.0
What problem does this PR solve?
Issue Number: close #16505 , close #16190
Problem Summary: TableIndexScan's result is different from TableFullScan and Selection.
What is changed and how it works?
What's Changed: If the where stmt only have String column, it shouldn't be one of accessCondition to build access range. Because we should convert the string to float to check it is ture/false.
How it Works: However, revert #16135 that only cover some cases. The pr can cover all situations.
Related changes
Check List
Tests
Release note