Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: build right range when where stmt only have string column. (#16645) #16660

Merged
merged 3 commits into from
May 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 21, 2020

cherry-pick #16645 to release-4.0


What problem does this PR solve?

Issue Number: close #16505 , close #16190

Problem Summary: TableIndexScan's result is different from TableFullScan and Selection.

What is changed and how it works?

What's Changed: If the where stmt only have String column, it shouldn't be one of accessCondition to build access range. Because we should convert the string to float to check it is ture/false.

How it Works: However, revert #16135 that only cover some cases. The pr can cover all situations.

Related changes

  • Need to cherry-pick to the release branch 2.1,3.0,3.1,4.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix the wrong result when where stmt only have string column.

@sre-bot sre-bot requested review from a team as code owners April 21, 2020 06:13
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

@wshwsh12 wshwsh12 force-pushed the release-4.0-0d5a83162b58 branch from 346ffcb to d0abe3e Compare April 22, 2020 03:21
@wshwsh12
Copy link
Contributor

Wait for #16559

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wshwsh12 please resolve conflict and fix CI.

@wshwsh12 wshwsh12 requested a review from winoros May 7, 2020 07:33
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2020
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label May 7, 2020
@zz-jason zz-jason removed the request for review from winoros May 7, 2020 08:47
@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 160c5c1 into pingcap:release-4.0 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/util sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants