Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16557

Merged
merged 4 commits into from
Apr 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 17, 2020

cherry-pick #16014 to release-3.0


What problem does this PR solve?

Issue Number: close #15986

What is changed and how it works?

When we use the string type to determine the bool value, the string type is converted to a float type instead of an int type.

Check List

Tests

  • Unit test
  • Integration test

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@Reminiscent
Copy link
Contributor

wait for tikv/tikv#7546

@Reminiscent
Copy link
Contributor

/run-all-tests tikv=pr/7546

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

@sre-bot, please update your pull request.

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent
Copy link
Contributor

@SunRunAway PTAL

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

@sre-bot merge failed.

@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

@sre-bot merge failed.

@SunRunAway SunRunAway merged commit 04baec7 into pingcap:release-3.0 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants