Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix window which depends on another (#11040) #16153

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 8, 2020

cherry-pick #11040 to release-3.0


What problem does this PR solve?

fix window function: A window which depends on another cannot define partitioning
#11007

What is changed and how it works?

Modify the order of error judgments

Check List

Tests

  • Unit test
  • Integration test

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot sre-bot added sig/planner SIG: Planner contribution This PR is from a community contributor. status/all-tests-passed type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 8, 2020
@sre-bot sre-bot requested review from alivxxx and SunRunAway April 8, 2020 03:58
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway requested a review from lzmhhh123 April 8, 2020 04:02
@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

Your auto merge job has been accepted, waiting for 16171, 16170, 16169, 16168, 16111, 16160, 16154

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

@sre-bot merge failed.

@zz-jason
Copy link
Member

/merge

@zz-jason zz-jason merged commit 1e84185 into pingcap:release-3.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants