Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix charset and collation for current_role (#16019) #16083

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 4, 2020

cherry-pick #16019 to release-3.0


What problem does this PR solve?

#15250 didn't set charset and collation for current_role correctly, which cause current_role print binary collation result.

What is changed and how it works?

fix charset and collation for current_role

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 4, 2020

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Apr 4, 2020

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 5, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit 10da321 into pingcap:release-3.0 Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants