planner/core: fix partition selection on hash partitioned table #16070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
type/bugfix
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@tiancaiamao merge failed. |
|
/run-all-tests tidb-test=pr/fix-16070 |
|
/run-all-tests tidb-test=pr/1030 |
|
/run-all-tests tidb-test=pr/1030 |
|
/rebuild tidb-test=pr/1030 |
|
/run-integration-common-test tidb-test=pr/1030 |
zz-jason
added
status/LGT2
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 4, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #16076 |
sre-bot
added a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
See the test case.
What is changed and how it works?
Remove redundancy code and get back the missing code
https://github.com/pingcap/tidb/compare/release-3.0...tiancaiamao:partition-selection-on-hash?expand=1#diff-0411f48b4045359c9f116ef6a779c3efR736-R740
This bug exists on branch 3.0, the master branch is fine.
Tests