Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distsql: fix wrong schema version when snapshot has been set (#15258) #15872

Merged
merged 5 commits into from
Mar 31, 2020
Merged

distsql: fix wrong schema version when snapshot has been set (#15258) #15872

merged 5 commits into from
Mar 31, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 30, 2020 •
edited by bb7133
Loading

cherry-pick #15258 to release-3.1

What problem does this PR solve?

As is stated in the title.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch (release-3.1

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Mar 30, 2020
Merged
@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.1-cherry-pick type/bugfix This PR fixes a bug. labels Mar 30, 2020
wshwsh12
wshwsh12 reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2020
crazycs520
crazycs520 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2020
@bb7133
Copy link
Member

bb7133 commented Mar 31, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 31, 2020

/run-all-tests

@sre-bot sre-bot merged commit b94693b into pingcap:release-3.1 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @crazycs520 @bb7133 @wshwsh12 @lzmhhh123