-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server, session: refine mysql handshake error log (#15731) #15798
Merged
zz-jason
merged 2 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-e42c82597982
Mar 30, 2020
Merged
server, session: refine mysql handshake error log (#15731) #15798
zz-jason
merged 2 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-e42c82597982
Mar 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
lysu
force-pushed
the
release-3.0-e42c82597982
branch
from
March 30, 2020 07:42
6818566
to
81c67ac
Compare
/run-all-tests |
zz-jason
reviewed
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jackysp
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 30, 2020
Your auto merge job has been accepted, waiting for 15849, 15709, 15621, 15865, 15258, 15852 |
zz-jason
added
status/all-tests-passed
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/usability
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15731 to release-3.0
What problem does this PR solve?
Problem Summary:
now, we log out too many EOF log due to port health check
What is changed and how it works?
make handshake EOF error be logged as
INFO
level(or debug?) and suspend stack info for themWhat's Changed:
How it Works:
log inside handshake method
Related changes
Check List
Tests
Side effects
Release note
refine mysql mysql handshake error log
This change is