Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server, session: refine mysql handshake error log (#15731) #15798

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 28, 2020

cherry-pick #15731 to release-3.0


What problem does this PR solve?

Problem Summary:

now, we log out too many EOF log due to port health check

What is changed and how it works?

make handshake EOF error be logged as INFO level(or debug?) and suspend stack info for them

What's Changed:

How it Works:

log inside handshake method

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test

Side effects

  • n/a

Release note

refine mysql mysql handshake error log


This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 28, 2020

/run-all-tests

@lysu lysu force-pushed the release-3.0-e42c82597982 branch from 6818566 to 81c67ac Compare March 30, 2020 07:42
@lysu
Copy link
Contributor

lysu commented Mar 30, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 30, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 30, 2020

Your auto merge job has been accepted, waiting for 15849, 15709, 15621, 15865, 15258, 15852

@zz-jason zz-jason added status/all-tests-passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2020
@zz-jason zz-jason merged commit 43a3dd0 into pingcap:release-3.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants