plan, expression: add date function support for hash partition (#15068) #15618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
sig/planner
jackysp
reviewed
Mar 24, 2020
| @@ -16,8 +16,9 @@ | |||
| "explain select * from t1 left join t2 on true where t1.a = 1 and false", | |||
| "explain select * from t1 left join t2 on true where t1.a = 1 and null", | |||
| "explain select * from t1 left join t2 on true where t1.a = null", | |||
| "explain select * from t1 where t1.a > 7 and t1.a < 3", | |||
| "explain select * from t1 where t1.a between 7 and 3" | |||
| // Case with date. | |||
|
LGTM |
tiancaiamao
approved these changes
Mar 25, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 15630 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #15068 withn conflict fixed.