-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix updating the column value when the column is dropping and in WriteOnly state (#15539) #15576
Conversation
Signed-off-by: sre-bot <[email protected]>
/run-all-tests |
Some variables and functions in v4.0 are not in v3.0, I hope that reviewers will be more careful |
planner/core/logical_plan_builder.go
Outdated
return i | ||
} | ||
} | ||
panic("Couldn't get column information when do update/delete") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Panic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add error for getTableOffset
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 15356 |
/run-all-tests |
cherry-pick #15539 to release-3.0
conflicts:
Some variables and functions in v4.0 are not in v3.0, I hope that reviewers will be more careful
What problem does this PR solve?
Issue Number: close #15386
Do the following:
The result:
Problem Summary:
When the column is dropping and in WriteOnly state, the value of this column cannot be explicitly updated.
What is changed and how it works?
What's Changed:
When the column is in a falling state and in WriteOnly state, if we update this column value explicitly, an error will be returned.
Related changes
Check List
Tests
Side effects
Release note