Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix select current_role() error (#15534) #15569

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 23, 2020

cherry-pick #15534 to release-3.0


What problem does this PR solve?

For user with no role, execute SET ROLE ALL, then SELECT CURRENT_ROLE()

mysql> set role all;
Query OK, 0 rows affected (0.00 sec)

mysql> select current_role();
ERROR 1105 (HY000): Missing session variable when eval builtin

Problem Summary:
This was caused by GetAllRole, which will return nil if user has no role.

What is changed and how it works?

let GetAllRole return a empty slice, rather than nil.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • None

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 23, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

Your auto merge job has been accepted, waiting for 15570

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit d56e4ff into pingcap:release-3.0 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants