-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: implement inspection_summary system table which organizes metrics by link/module #14810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alivxxx and
lzmhhh123
and removed request for
a team
February 17, 2020 01:18
…/link Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
lonng
changed the title
[WIP] *: inspection summary
*: implement inspection_summary system table which organizes metrics by link/module
Feb 18, 2020
lonng
requested review from
crazycs520 and
Deardrops
and removed request for
alivxxx and
lzmhhh123
February 18, 2020 05:15
Deardrops
reviewed
Feb 18, 2020
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
Deardrops
reviewed
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crazycs520
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crazycs520
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 18, 2020
/run-all-tests |
lonng
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There are many metrics in the TiDB cluster and the users have no idea to use which metrics to locate the problem in the cluster because our metrics have not been organized in an efficient approach.
What is changed and how it works?
This PR try to introduce a system table
inspection_summary
, which is used to organize our metrics by read/write link or modules, e.g:read-link
is used to organize all metrics in the reading query execution path via the top-bottom form.write-link
is used to organize all metrics in the writting query execution path via the top-bottom form.wait-events
is used to organize allduration
metricsddl
/txn
/rocksdb
/raftstore
...NOTE
InspectionSummaryRetriever
, which means there is no extra cost in unused rules, e.g:select * from inspection_summary where rule='read-link'
only retrieve metrics related to the reading link. The supported push-down columns:rule
,metric_name
.quantile
can be specified as an arbitrary positive number(s) by the user. e.g:select * from inspection_summary where rule='read-link' and quantile=0.999
orselect * from inspection_summary where rule='read-link' and quantile in (0.80, 0.90, 0.99, 0.999, 1)
.TODO
The value columns in the result should be a
Double(22,6)
, but there will be many changes to fix this issue. It will be addressed in the next PR because this PR is so huge and will lose reviewability as diff growth.Check List
Tests
Release note
inspection_summary
which is used to organizes metrics by link/module