executor: add diagnosis rule to detect cluster critical errors #14743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng <[email protected]>
crazycs520
reviewed
Feb 12, 2020
Signed-off-by: Lonng <[email protected]>
Deardrops
approved these changes
Feb 13, 2020
| }, | ||
| } | ||
|
|
||
| for _, cas := range cases { |
There was a problem hiding this comment.
Suggested change
| for _, cas := range cases { | |
| for _, case := range cases { |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR adds a new diagnosis rule, which is used to detect whether critical errors occurred in the cluster. We will detect the following metrics tables in the current implementation:
tidb_failed_query_opmtikv_critical_errortidb_panic_counttidb_binlog_error_countpd_cmd_fail_opstidb_kv_region_error_opstidb_lock_resolver_opstikv_scheduler_is_busytikv_coprocessor_is_busytikv_channel_full_totaltikv_coprocessor_request_errortidb_schema_lease_error_opmtidb_transaction_retry_error_opstikv_grpc_errorsWhat is changed and how it works?
Check the metrics table and check whether some errors occurred in the past.
Check List
Tests
Release note
critical-errorwhich is used to detect cluster critical errors