expression: implement the Coercibility() function #14739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
qw4990
requested review from
winoros,
wjhuang2016,
bb7133 and
a team
and removed request for
SunRunAway and
XuHuaiyu
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
wjhuang2016
reviewed
Feb 12, 2020
| if _, ok := sysConstFuncs[sf.FuncName.L]; ok { | ||
| return CoercibilitySysconst | ||
| } | ||
| if !types.IsString(sf.RetType.Tp) { |
There was a problem hiding this comment.
What if Bytes, the collation is binary
There was a problem hiding this comment.
mysql> create table tt (b binary(10), vb varbinary(10));
mysql> insert into tt values (null, null);
mysql> select coercibility(b), coercibility(vb) from tt;
+-----------------+------------------+
| coercibility(b) | coercibility(vb) |
+-----------------+------------------+
| 2 | 2 |
+-----------------+------------------+
After testing, it seems ok to use this function since the Tp of Bytes(binary) in TiDB is 254(TypeString) now.
bb7133
reviewed
Feb 12, 2020
|
/rebuild |
wjhuang2016
approved these changes
Feb 13, 2020
qw4990
added
status/can-merge
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/run-integration-common-test |
1 similar comment
|
/run-integration-common-test |
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Solve this issue: #14687.
Implement the
Coercibility()function for TiDB.What is changed and how it works?
CollationExprand implement it for all ourExpressionsderiveCoercibilityForXXXfunctions according to this doc.Check List
Tests