Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add check data visibility for point get (#14459) #14480

Merged
merged 3 commits into from
Jan 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 15, 2020

cherry-pick #14459 to release-3.0


What problem does this PR solve?

Before this PR, The Point-Get doesn't check the transaction start TS too old that older than GC safe point time. Then, if the record data was clean by GC, but index data was not, the User will get the error like inconsistent extra index..., This error message will confuse the user.

What is changed and how it works?

Add CheckVisibility for point get.

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

  • add check data visibility for point get.

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

/run-all-tests

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jan 15, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

Your auto merge job has been accepted, waiting for 14479

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

/run-all-tests

@jackysp jackysp merged commit 87fdf87 into pingcap:release-3.0 Jan 15, 2020
@bb7133 bb7133 added this to the v3.0.10 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants