executor: add privilege check for show bindings #14443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bugfix
ghost
removed their request for review
eurekaka
reviewed
Jan 14, 2020
executor/show.go
Outdated
| schema = v.defaultDB | ||
| } | ||
| if !v.is.TableExists(model.NewCIStr(schema), x.Name) { | ||
| v.ok = false |
There was a problem hiding this comment.
How about setting v.ok to true if table does not exist in the information schema?
There was a problem hiding this comment.
v.ok=v.is.TableExists(model.NewCIStr(schema), x.Name)?
There was a problem hiding this comment.
@eurekaka Why? If the table does not exist anymore, why should we show it?
@crazycs520 No, ok may change from fasle to true then, which should not happen.
There was a problem hiding this comment.
If the table is re-created, then the binding would be shown then? would it confuse users since they don't touch bindings actually but the results change?
eurekaka
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Feb 4, 2020
sre-bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add privilege check for show bindings.
What is changed and how it works?
A binding will only be appended to result if the user has all tables' select priviledge in the sql.
Check List
Tests
Code changes
Side effects
Related changes
Release note