coprocessor: add ddl schema version in request #14317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/enhancement
|
/run-all-tests |
tiancaiamao
reviewed
Jan 8, 2020
lzmhhh123
force-pushed
the
dev/add_schema_ver_in_cop
branch
from
82811ad to
1f41051
Compare
|
LGTM |
wjhuang2016
reviewed
Jan 8, 2020
| @@ -165,6 +165,7 @@ func (builder *RequestBuilder) SetFromSessionVars(sv *variable.SessionVars) *Req | |||
| builder.Request.NotFillCache = sv.StmtCtx.NotFillCache | |||
| builder.Request.Priority = builder.getKVPriority(sv) | |||
| builder.Request.ReplicaRead = sv.GetReplicaRead() | |||
| builder.Request.SchemaVar = sv.TxnCtx.SchemaVersion | |||
There was a problem hiding this comment.
Please update the comment of this function.
There was a problem hiding this comment.
Emmm, please update Priority in comment too.
SunRunAway
added
status/LGT2
SunRunAway
approved these changes
Jan 8, 2020
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When DDL has changed. TiFlash needs to know the DDL change to decode the correct data. So for TiFlash, it hopes TiDB lets it know the newest schema version in coprocessor request.
What is changed and how it works?
Set the
SchemaVerforcoprocessor.Request.Check List
Tests
Code changes
Side effects