Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add SHUTDOWN command and privilege check (#12804) #14104

Merged
merged 5 commits into from
Dec 19, 2019
Merged

executor: add SHUTDOWN command and privilege check (#12804) #14104

merged 5 commits into from
Dec 19, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Dec 18, 2019 •
edited
Loading

cherry-pick #12804 to 3.0

need merge with pingcap/parser#688

This change is Reviewable

@lysu lysu mentioned this pull request Dec 18, 2019
Merged
@lysu
Copy link
Contributor Author

lysu commented Dec 18, 2019

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Dec 18, 2019

/run-all-tests

@lysu lysu added sig/execution SIG execution contribution This PR is from a community contributor. labels Dec 18, 2019
jackysp
jackysp reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imtbkcat
imtbkcat reviewed Dec 18, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

session/bootstrap.go Outdated Show resolved Hide resolved
@lysu
Copy link
Contributor Author

lysu commented Dec 18, 2019

/run-all-tests

@lysu lysu requested review from jackysp and imtbkcat December 18, 2019 12:15
imtbkcat
imtbkcat approved these changes Dec 19, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Dec 19, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit f2ae63e into pingcap:release-3.0 Dec 19, 2019
@lysu lysu deleted the dev-cp30-shutdown branch January 3, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtbkcat imtbkcat imtbkcat approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysu @jackysp @sre-bot @imtbkcat @ekalinin