planner: fix wrong stats for physical union scan #14093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/bugfix
ghost
requested review from
alivxxx and
winoros
and removed request for
a team
eurekaka
reviewed
Dec 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #14093 +/- ##
===========================================
Coverage ? 80.1538%
===========================================
Files ? 483
Lines ? 121434
Branches ? 0
===========================================
Hits ? 97334
Misses ? 16343
Partials ? 7757 |
alivxxx
previously approved these changes
Dec 18, 2019
alivxxx
added
the
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
alivxxx
approved these changes
Dec 19, 2019
|
/merge |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Dec 19, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Dec 19, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The stats for PhysicalUnionScan should be its physical child. But we set the stats as its logical child's stats. That's wrong.
What is changed and how it works?
Change the stats dynamically in
findBestTask.Check List
Tests
Side effects
Related changes