Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONRemoveSig #14074

Merged
merged 4 commits into from
Dec 18, 2019
Merged

expression: implement vectorized evaluation for builtinJSONRemoveSig #14074

merged 4 commits into from
Dec 18, 2019

Conversation

shihongzhi
Copy link
Member

@shihongzhi shihongzhi commented Dec 16, 2019 •
edited
Loading

What problem does this PR solve?

implement vectorized evaluation for builtinJSONRemoveSig , for #12104

What is changed and how it works?

$go test -v -benchmem -bench=BenchmarkVectorizedBuiltinJSONFunc -run=BenchmarkVectorizedBuiltinJSONFunc -args "builtinJSONRemoveSig"
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONRemoveSig-VecBuiltinFunc-4                    1237            969097 ns/op          481553 B/op       6698 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONRemoveSig-NonVecBuiltinFunc-4                 1141            995345 ns/op          480680 B/op       6697 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      3.825s

Check List

Tests

  • Unit test

@shihongzhi shihongzhi requested a review from a team as a code owner December 16, 2019 09:14
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team December 16, 2019 09:14
@codecov
Copy link

codecov bot commented Dec 16, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ad1a15d). Click here to learn what that means.
The diff coverage is 55%.

@@             Coverage Diff             @@
##             master     #14074   +/-   ##
===========================================
  Coverage          ?   80.1532%           
===========================================
  Files             ?        483           
  Lines             ?     121274           
  Branches          ?          0           
===========================================
  Hits              ?      97205           
  Misses            ?      16312           
  Partials          ?       7757

@XuHuaiyu
Copy link
Contributor

Why the vectorized-implementation is slower than the non-vec implementation?

@wshwsh12 wshwsh12 added contribution This PR is from a community contributor. component/expression labels Dec 16, 2019
@shihongzhi
Copy link
Member Author

Why the vectorized-implementation is slower than the non-vec implementation?

maybe my computer have some problem at that time for running benchmark.
I run benchmark many time today and update the benchmark info.

$go test -v -benchmem -bench=BenchmarkVectorizedBuiltinJSONFunc -run=BenchmarkVectorizedBuiltinJSONFunc -args "builtinJSONRemoveSig"
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONRemoveSig-VecBuiltinFunc-4                    1237            969097 ns/op          481553 B/op       6698 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONRemoveSig-NonVecBuiltinFunc-4                 1141            995345 ns/op          480680 B/op       6697 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      3.825s

pls review again

wshwsh12
wshwsh12 reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2019
qw4990
qw4990 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

Your auto merge job has been accepted, waiting for 14090

@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

@shihongzhi merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Dec 18, 2019

/run-unit-test

@qw4990 qw4990 merged commit 9d22210 into pingcap:master Dec 18, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@shihongzhi @XiaTianliang
expression: implement vectorized evaluation for builtinJSONRemoveSig (
e182de8 
pingcap#14074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shihongzhi @XuHuaiyu @sre-bot @qw4990 @wshwsh12