*: refine some error code #14002
Merged
*: refine some error code #14002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define some customized mysql.ErrCode in the parser and use them for the following packages: * server * meta/autoid * sessionctx/variable * privilege/privileges
tiancaiamao
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #14002 +/- ##
===========================================
Coverage 80.2959% 80.2959%
===========================================
Files 482 482
Lines 121361 121361
===========================================
Hits 97448 97448
Misses 16187 16187
Partials 7726 7726 |
|
Please resolve the conflicts, @tiancaiamao . |
|
Done @jackysp |
jackysp
approved these changes
Dec 12, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@tiancaiamao merge failed. |
|
/run-unit-test |
|
The test failed, @tiancaiamao . |
|
/merge |
|
Your auto merge job has been accepted, waiting for 14032 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make the error code explicable when it's returned to MySQL client.
What is changed and how it works?
Define some customized mysql.ErrCode in the parser and use them for the following packages:
Check List
Tests