expression : fix function 'binSearch' in builtinIntervalRealSig not return error (#12957) #13768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/expression
contribution
|
/run-unit-test |
Reminiscent
added
status/can-merge
|
Sorry @Reminiscent, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #12957 to release-2.1
What problem does this PR solve?
When I implemented the vectorization interface, I found a tiny error in the builtin_compare.go file.
So I fixed it
What is changed and how it works?
In the binsreach function, when we call
EvalReal, the return value iserr1, but when we judge the error, we checkerr, thiserris always empty, which causes us to not captureEvalRealThe error returned.Check List
Tests