planner/core: fix not null flag for using and natural join #13735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13735 +/- ##
===========================================
Coverage 80.2607% 80.2607%
===========================================
Files 473 473
Lines 117127 117127
===========================================
Hits 94007 94007
Misses 15801 15801
Partials 7319 7319 |
eurekaka
added
the
status/can-merge
|
Does this PR need to be cherry-picked? |
|
Yes, updated the label. |
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Nov 26, 2019
ngaut
pushed a commit
that referenced
this pull request
Nov 26, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When there is using clause or natural in outer join, the not null flag for inner plan is not properly reset.
What is changed and how it works?
Reset the not null flag for the inner child of using and natural join when build the schema.
Check List
Tests
Code changes
Side effects
Related changes
Release note