stats: fix data race when updating stats cache (#13647) #13687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/statistics
type/3.0 cherry-pick
type/bugfix
eurekaka
approved these changes
Nov 22, 2019
eurekaka
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #13647 to release-3.0
What problem does this PR solve?
When stats update cache, it does not consider that there maybe another writter at the same time, so it is possible that the newer updates maybe rewritten by older updates, which lead to after a call of
Update, it does has the latest stats cache.What is changed and how it works?
Store the
latestVersionat the same place with stats cache, so we need to updat e them together and check their versions when updating.Check List
Tests
Code changes
Side effects
Related changes
Release note