-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression : fix bug in insert select union select. #13632
Conversation
6ee7ca5
to
f0e509f
Compare
Codecov Report
@@ Coverage Diff @@
## master #13632 +/- ##
================================================
- Coverage 80.3499% 79.9168% -0.4332%
================================================
Files 473 473
Lines 118117 115664 -2453
================================================
- Hits 94907 92435 -2472
- Misses 15857 15966 +109
+ Partials 7353 7263 -90 |
/run-unit-test |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-3.0 failed |
cherry pick to release-2.1 failed |
What problem does this PR solve?
In TiDB:
Result:
Expected execute successfully!
What is changed and how it works?
This problem comes from
jsonUnquoteFunction
function.We should fill the Flen in
jsonUnquoteFunctionClass.getFunction()
.Cause return type
string
is an element set (maybe autowrapped as an array) of whole json, so here we set the flen withmysql.MaxFieldVarCharLength
.Check List
Tests
Related changes
Release note