Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use ExtraHandleColumn as PK when generating TablePath (#11959) #13294

Merged
merged 6 commits into from
Nov 11, 2019

Conversation

francis0407
Copy link
Member

@francis0407 francis0407 commented Nov 8, 2019

What problem does this PR solve?

Cherry pick #11959 to branch release-2.1

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

When the table uses _tidb_rowid as Handle, we can correctly generate a TableScan that keeps the order of _tidb_rowid. For example, select max(_tidb_rowid) from t won't require a Sort anymore.

@francis0407 francis0407 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Nov 8, 2019
@francis0407
Copy link
Member Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Nov 9, 2019
@francis0407 francis0407 requested a review from eurekaka November 11, 2019 08:00
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13338

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2c6ebe5 into pingcap:release-2.1 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants