Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: annotate the previous statement to the error when transaction commit failed (#12087) (#12199) #13248

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 7, 2019

What problem does this PR solve?

Cherry pick (#12199) to release 3.1.
No conflicts.

@jackysp jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Nov 7, 2019
@jackysp jackysp requested review from lysu and crazycs520 November 7, 2019 11:30
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

/run-all-tests

@sre-bot sre-bot merged commit 56878d9 into pingcap:release-3.1 Nov 7, 2019
@jackysp jackysp deleted the commit_error_3.1 branch February 27, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants